[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-28 Thread Mandeep Singh Grang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319222: [OpenMP] Stable sort Privates to remove non-deterministic ordering (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D39947?vs=122751&id=124622#toc Repository: rL LLVM

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-20 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. Yes, LGTM. Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-20 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-20 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. Ping for reviews please. Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-13 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. In https://reviews.llvm.org/D39947#922987, @rjmccall wrote: > In https://reviews.llvm.org/D39947#922922, @mgrang wrote: > > > In https://reviews.llvm.org/D39947#922889, @rjmccall wrote: > > > > > In https://reviews.llvm.org/D39947#922870, @mgrang wrote: > > > > > > > Altho

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-13 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang updated this revision to Diff 122751. mgrang added a comment. Fixed the sorting order for stable_sort. Repository: rL LLVM https://reviews.llvm.org/D39947 Files: lib/CodeGen/CGOpenMPRuntime.cpp Index: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-13 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D39947#922922, @mgrang wrote: > In https://reviews.llvm.org/D39947#922889, @rjmccall wrote: > > > In https://reviews.llvm.org/D39947#922870, @mgrang wrote: > > > > > Although this patches fixes the above unit test failures, the generated > >

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-12 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. In https://reviews.llvm.org/D39947#922889, @rjmccall wrote: > In https://reviews.llvm.org/D39947#922870, @mgrang wrote: > > > Although this patches fixes the above unit test failures, the generated > > code is very different from the one that the tests expect. As a result

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D39947#922870, @mgrang wrote: > Although this patches fixes the above unit test failures, the generated code > is very different from the one that the tests expect. As a result, these > tests need to be adjusted. Could the reviewers please c

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-12 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. Although this patches fixes the above unit test failures, the generated code is very different from the one that the tests expect. As a result, these tests need to be adjusted. Could the reviewers please comment/suggest on whether it is ok to fix the tests as a result of

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

2017-11-12 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang created this revision. mgrang added a project: clang. This fixes the following failures uncovered by https://reviews.llvm.org/D39245: Clang :: OpenMP/task_firstprivate_codegen.cpp Clang :: OpenMP/task_private_codegen.cpp Clang :: OpenMP/taskloop_firstprivate_codegen.cpp Clang :: Op