[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

2017-11-10 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Thanks. I'll update it to incorporate the lately committed test fixes, and push it later today. Repository: rL LLVM https://reviews.llvm.org/D39763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

2017-11-10 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I can't really check if all the tests are equivalent to the old ones, but not having to install nose is a major usability improvement. Let's ship this. We should totally fix the existing fai

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

2017-11-07 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Before: == FAIL: tests.cindex.test_code_completion.test_code_complete_availability -- Traceback (most recent call last): File

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

2017-11-07 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. The diffs aren't very useful since I had to add a class for each test unit and so everything needed reindenting. You can take my word that changes boil down to: - adding `unittest` import, - adding class for each test unit and converting the functions into methods (exce