dschuff added a comment.
Yes; in particular, musl's implementation of printf has some code where it
promotes everything to long double, so if long double is f128, that causes
several of these functions to get linked in to every binary, for no real
benefit to the user.
Repository:
rL LLVM
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317601: [WebAssembly] Include GENERIC_TF_SOURCES in wasm
builds (authored by sbc).
Repository:
rL LLVM
https://reviews.llvm.org/D39748
Files:
compiler-rt/trunk/lib/builtins/CMakeLists.txt
Index: c
sbc100 added a comment.
My guess was that it was "long-double-is-f128" that was causing clang to
generate references to these symbols, but I wasn't totally sure.. its only
aarch64 and mips64 that seem to require these thus far.
https://reviews.llvm.org/D39748
___
dschuff added a comment.
Yeah. Or not; I think you can still use `__float128` types in clang, so if you
did that then it would use these methods too. And as long as `long double` is
f64 then none of these functions would get pulled into every program that uses
printf (which is the case now), s
sbc100 added a comment.
I guess if we make that change we can revert this one?
https://reviews.llvm.org/D39748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dschuff added a comment.
Also btw I still think I want to back out the "long-double-is-f128" ABI from
wasm. But either way it probably doesn't hurt to have these in compiler-rt.
https://reviews.llvm.org/D39748
___
cfe-commits mailing list
cfe-commi
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
BTW I'm still trying to get caught up, so if there's some review or something
you have in flight that you want me to get to first, just let me know.
https://reviews.llvm.org/D39748
_
