b-sumner added a comment.
In https://reviews.llvm.org/D39739#1045611, @ashi1 wrote:
> Is first one encountered a poor design?
Strong or first weak is the standard behavior for ISA level linkers.
Repository:
rL LLVM
https://reviews.llvm.org/D39739
ashi1 added a comment.
Herald added a subscriber: llvm-commits.
Is first one encountered a poor design?
Repository:
rL LLVM
https://reviews.llvm.org/D39739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
yaxunl added a comment.
In https://reviews.llvm.org/D39739#945318, @b-sumner wrote:
> The usual rule is to take the first weak definition encountered.
Will this work for us? Usually we would like the last one to be linked.
Repository:
rL LLVM
https://reviews.llvm.org/D39739
b-sumner added a comment.
The usual rule is to take the first weak definition encountered.
Repository:
rL LLVM
https://reviews.llvm.org/D39739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
yaxunl added inline comments.
Comment at: lib/Transforms/IPO/FunctionImport.cpp:107
+static cl::opt
+ForceImportWeak("force-import-weak", cl::Hidden,
+cl::desc("Allow weak functions to be imported"),
AlexVlx wrote:
> yaxunl wrote:
> > Is it possib
AlexVlx added inline comments.
Comment at: lib/Transforms/IPO/FunctionImport.cpp:107
+static cl::opt
+ForceImportWeak("force-import-weak", cl::Hidden,
+cl::desc("Allow weak functions to be imported"),
yaxunl wrote:
> Is it possible not to expose t
yaxunl added inline comments.
Comment at: lib/Transforms/IPO/FunctionImport.cpp:107
+static cl::opt
+ForceImportWeak("force-import-weak", cl::Hidden,
+cl::desc("Allow weak functions to be imported"),
Is it possible not to expose this option throug
ashi1 updated this revision to Diff 122271.
ashi1 added subscribers: scchan, yaxunl, ashi1.
ashi1 added a comment.
Herald added a subscriber: eraman.
I've added the lit tests for this change, and also showing full context.
My lit test import_weak_type.ll follows similar format to import_opaque_ty
