francisco.lopes added a comment.
OK. I do agree serialization, etc, is a stumbling block on delivering large
results fast. I just wanted to warn on this because I've just seen ycmd devs
went through this, where sorting was one of the bottlenecks, like, to
`std::sort` 43k results instead of simp
sammccall added a comment.
In https://reviews.llvm.org/D39738#921103, @francisco.lopes wrote:
> I'm still in the process of construction of a general jsonrpc/LSP client and
> didn't start consuming clangd yet.
If you concerns about clangd's responsiveness, I recommend testing using
VSCode, wh
francisco.lopes added a comment.
I'm still in the process of construction a general jsonrpc client and didn't
start consuming clangd yet. But, I do have previous experience with libclang,
and I don't know whether clangd will be able to return completion results at
global scope (not necessarily
sammccall added a comment.
In https://reviews.llvm.org/D39738#921014, @francisco.lopes wrote:
> Sorting got hardcoded? libclang has it optional. If hardcoded, it becomes a
> performance problem, since some clients may wish to order it themselves with
> private heuristics.
Is the performance r
francisco.lopes added a comment.
Sorting got hardcoded? libclang has it optional. If hardcoded it becomes a
performance problem, since some clients may wish to order it themselves with
private heuristics.
Repository:
rL LLVM
https://reviews.llvm.org/D39738
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317670: [clangd] Sort completion results. (authored by
sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D39738
Files:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
clang-tools-extra/trunk/
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D39738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
sammccall created this revision.
Herald added a subscriber: ilya-biryukov.
This is (probably) not required by LSP, but at least one buggy client wants it.
It also simplifies some tests - changed a few completion tests to use -pretty.
https://reviews.llvm.org/D39738
Files:
clangd/ClangdUnit.cp
