This revision was automatically updated to reflect the committed changes.
Closed by commit rL317559: [clangd] Add ErrorCode enum class. (authored by
hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D39718
Files:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra/tru
hokein updated this revision to Diff 121858.
hokein added a comment.
Address review comments:
- ErrorCodes => ErrorCode
- Remove serverErrorStart/serverErrorEnd
https://reviews.llvm.org/D39718
Files:
clangd/ClangdLSPServer.cpp
clangd/JSONRPCDispatcher.cpp
clangd/JSONRPCDispatcher.h
cla
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Protocol.h:35
+enum class ErrorCodes {
+ // Defined by JSON RPC.
nit: could you call this ErrorCode? The plural doesn't make
hokein created this revision.
Herald added a subscriber: ilya-biryukov.
Avoid using magic number in the code everywhere.
https://reviews.llvm.org/D39718
Files:
clangd/ClangdLSPServer.cpp
clangd/JSONRPCDispatcher.cpp
clangd/JSONRPCDispatcher.h
clangd/Protocol.h
Index: clangd/Protocol.h
