[PATCH] D39691: [analyzer] Model correct dispatch_once() 'done' value in BodyFarm

2017-11-06 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. Yeah, I'm not a fan of this style of testing for path diagnostics, either. https://reviews.llvm.org/D39691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39691: [analyzer] Model correct dispatch_once() 'done' value in BodyFarm

2017-11-06 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Looks good to me. I really don't think the test format chosen in `unix-fns.c` is a good idea, as it is very large, auto-generated, and tightly coupled to chosen formatting.