craig.topper added a comment.
Ok then we can keep the new test.
I believe the isValidFeature list was copied from the list in hasFeature. But
isValidFeature should match the names used by initFeatureMap since that's what
we use to look them up.
https://reviews.llvm.org/D39631
_
mstorsjo added a comment.
In https://reviews.llvm.org/D39631#915943, @craig.topper wrote:
> Can we just add -Werror to test/CodeGen/3dnow-builtins.c to test this?
That file actually already has got `-Werror`
> I believe it should be throwing a warning currently.
It doesn't. That test enable
craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.
Can we just add -Werror to test/CodeGen/3dnow-builtins.c to test this? I
believe it should be throwing a warning currently.
Can we also remove mm3dnow and mm3dnowa from
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
mstorsjo created this revision.
These were missed in SVN r316783, which broke compiling mingw-w64 CRT.
https://reviews.llvm.org/D39631
Files:
lib/Basic/Targets/X86.cpp
test/Headers/mm3dnow.c
Index: test/Headers/mm3dnow.c
===
