This revision was automatically updated to reflect the committed changes.
Closed by commit rL318598: [CodeGen] change const-ness of complex calls
(authored by spatel).
Changed prior to commit:
https://reviews.llvm.org/D39611?vs=122474&id=123467#toc
Repository:
rL LLVM
https://reviews.llvm.o
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
spatel added a comment.
Ping.
https://reviews.llvm.org/D39611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spatel updated this revision to Diff 122474.
spatel added a comment.
Patch updated:
Except for cimag, cproj, conj, and creal, everything in is marked 'e'
- the functions are not const if we might set errno.
https://reviews.llvm.org/D39611
Files:
include/clang/Basic/Builtins.def
test/CodeG
hfinkel added a comment.
In https://reviews.llvm.org/D39611#921923, @spatel wrote:
> Thanks for the clarification!
>
> If I'm reading this properly, we should make the same kind of change as in
> https://reviews.llvm.org/D39481 ('c' -> 'e') for most of complex.h. Ie, the
> standard allows errno
spatel added a comment.
Thanks for the clarification!
If I'm reading this properly, we should make the same kind of change as in
https://reviews.llvm.org/D39481 ('c' -> 'e') for most of complex.h. Ie, the
standard allows errno-setting, and it's (unfortunately for optimization) even
more clearl
hfinkel added a comment.
In https://reviews.llvm.org/D39611#918654, @hfinkel wrote:
> In https://reviews.llvm.org/D39611#918275, @spatel wrote:
>
> > Patch updated:
> > I don't know if we have agreement on the behavior that we want yet,
>
>
> I just sent a note to the Austin group mailing list t
hfinkel added a comment.
In https://reviews.llvm.org/D39611#918275, @spatel wrote:
> Patch updated:
> I don't know if we have agreement on the behavior that we want yet,
I just sent a note to the Austin group mailing list to see if the POSIX folks
agree with my reading. I'll follow up.
> but
spatel updated this revision to Diff 121949.
spatel retitled this revision from "[CodeGen] make cbrt and fma constant (never
set errno); document complex calls as always constant" to "[CodeGen] change
const-ness of complex calls".
spatel edited the summary of this revision.
spatel added a comment
