This revision was automatically updated to reflect the committed changes.
Hahnfeld marked an inline comment as done.
Closed by commit rL318601: [OpenMP] Show error if VLAs are not supported
(authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D39505?vs=123364&id=123473#toc
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, seems fine. Thanks for putting up with my questions.
https://reviews.llvm.org/D39505
___
cfe-commits mailing list
cfe-commits@lists.ll
Hahnfeld marked an inline comment as done.
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> H
Hahnfeld updated this revision to Diff 123364.
Hahnfeld added a comment.
Update changes to be generic.
https://reviews.llvm.org/D39505
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/TargetInfo.h
include/clang/Sema/Sema.h
lib/Basic/TargetInfo.cpp
lib/Basic/Target
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > ABataev wrote:
> > > Hah
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> ABataev wrote:
> > Hahnfeld wrote:
> > > rjm
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
ABataev wrote:
> Hahnfeld wrote:
> > rjmccall wrote:
> > > Hah
ABataev added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > Hahnfeld wrote:
> > > rjm
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> Hahnfeld wrote:
> > rjmccall wrote:
> > > Ha
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > Hahnfeld wrote:
> > > rj
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> Hahnfeld wrote:
> > rjmccall wrote:
> > > AB
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > ABataev wrote:
> > > ABa
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> ABataev wrote:
> > ABataev wrote:
> > > Hahn
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
ABataev wrote:
> ABataev wrote:
> > Hahnfeld wrote:
> > > rjmc
ABataev added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
ABataev wrote:
> Hahnfeld wrote:
> > rjmccall wrote:
> > > Hahn
ABataev added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > Hahnfeld wrote:
> > > rjm
Hahnfeld marked an inline comment as done.
Hahnfeld added a subscriber: gtbercea.
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > Hahnfeld wrote:
> > > rj
Hahnfeld marked 3 inline comments as done.
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> H
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > The way you've written t
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> The way you've written this makes it sound l
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
The way you've written this makes it sound like "does the targ
Hahnfeld created this revision.
Herald added a subscriber: jholewinski.
Some target devices (e.g. Nvidia GPUs) don't support dynamic stack
allocation and hence no VLAs. Print errors with description instead
of failing in the backend or generating code that doesn't work.
This patch handles explici
23 matches
Mail list logo
