djasper closed this revision.
djasper added a comment.
Submitted as r317901.
https://reviews.llvm.org/D39478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sugak added a comment.
@djasper: no, I do not.
https://reviews.llvm.org/D39478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper accepted this revision.
djasper added a comment.
Looks good. Do you have submit access?
https://reviews.llvm.org/D39478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sugak added a comment.
@djasper: ping :)
https://reviews.llvm.org/D39478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sugak updated this revision to Diff 121165.
sugak marked 3 inline comments as done.
sugak added a comment.
Updated per comments.
@djasper : Thank you for the review! Would you commit this for me?
https://reviews.llvm.org/D39478
Files:
lib/Format/UsingDeclarationsSorter.cpp
unittests/Format
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Some minor remarks, but generally looks good. Thanks for fixing this!
Comment at: lib/Format/UsingDeclarationsSorter.cpp:136
for (size_t I = 0, E = AnnotatedLines.size()
sugak added inline comments.
Comment at: lib/Format/UsingDeclarationsSorter.cpp:50
std::string computeUsingDeclarationLabel(const FormatToken *UsingTok) {
assert(UsingTok && UsingTok->is(tok::kw_using) && "Expecting a using token");
std::string Label;
and
sugak created this revision.
This fixes clang-format internal assertion for the following code:
/* override */ using std::string;
Added add a unit test.
https://reviews.llvm.org/D39478
Files:
lib/Format/UsingDeclarationsSorter.cpp
unittests/Format/UsingDeclarationsSorterTest.cpp
Index
