This revision was automatically updated to reflect the committed changes.
Closed by commit rL317065: [Analyzer] Use value storage for BodyFarm (authored
by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39428?vs=120861&id=121098#toc
Repository:
rL LLVM
https://reviews
dcoughlin accepted this revision.
dcoughlin added a comment.
Looks good to me with the comments by Gabor addressed.
In https://reviews.llvm.org/D39428#912126, @george.karpenkov wrote:
> On top of that, reference is part of the type, not part of the variable name,
The reference is parsed as par
zaks.anna added a comment.
> Also if you check the code snippets in the coding standard:
> https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto
> you can see that where we officially put the references.
Correct! The reference should not go with the type name.
George, p
xazax.hun added a comment.
In https://reviews.llvm.org/D39428#912126, @george.karpenkov wrote:
> @xazax.hun I'm really not convinced:
Unfortunately, the LLVM codebase right now does not strictly follow the style
guide. But clang-format puts the references next to the variable (or function
in
george.karpenkov added a comment.
@xazax.hun I'm really not convinced:
george@/Volumes/Transcend/code/llvm (master)≻ rg "\w+\&"
tools/clang/include/clang/StaticAnalyzer
tools/clang/include/clang/StaticAnalyzer/Core/Checker.h
31: static void _checkDecl(void *checker, const Decl *D, Analysi
xazax.hun accepted this revision.
xazax.hun added a comment.
Some minor nits otherwise LGTM!
Comment at: include/clang/Analysis/AnalysisDeclContext.h:479
+ /// Get a reference to {@code BodyFarm} instance.
+ BodyFarm& getBodyFarm();
The reference is on the
george.karpenkov updated this revision to Diff 120861.
https://reviews.llvm.org/D39428
Files:
include/clang/Analysis/AnalysisDeclContext.h
include/clang/Analysis/BodyFarm.h
lib/Analysis/AnalysisDeclContext.cpp
Index: lib/Analysis/AnalysisDeclContext.cpp
===
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good - thanks!
https://reviews.llvm.org/D39428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
george.karpenkov created this revision.
Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar,
aemerson.
I've also removed copy constructor to help clients not to shoot themselves in
the foot with `BodyFarm stored = Manager.getBodyFarm()`.
https://reviews.llvm.org/D39428
Fil
