[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

2017-10-27 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316807: [MS] Allow access to ambiguous, inaccessible direct bases (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D39389?vs=120694&id=120713#toc Repository: rL LLVM https://revi

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

2017-10-27 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yuck, LGTM :) https://reviews.llvm.org/D39389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

2017-10-27 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. When you say "latest Windows SDK headers", do you mean SDK version 10.0.16299.15? https://reviews.llvm.org/D39389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

2017-10-27 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. Clang typically warns that in the following class hierarchy, 'A' is inaccessible because there is no series of casts that the user can write to access it unambiguously: struct A { }; struct B : A { }; struct C : A, B { }; MSVC allows the user to convert from C* t