Agreed! Just wanted to do it but then I noticed that there's already one
that landed in r307791! :)
On Sun, Oct 29, 2017 at 2:06 PM, Kim Gräsman wrote:
> A clang-tidy check to remove empty messages from source would be nice,
> though...
>
> - Kim
>
> Den 27 okt. 2017 10:24 fm skrev "Nicolas Less
A clang-tidy check to remove empty messages from source would be nice,
though...
- Kim
Den 27 okt. 2017 10:24 fm skrev "Nicolas Lesser via Phabricator" <
revi...@reviews.llvm.org>:
> Rakete abandoned this revision.
> Rakete added a comment.
>
> @kimgr Well, mostly because they bother me
Rakete abandoned this revision.
Rakete added a comment.
@kimgr Well, mostly because they bother me a bit, don't know what others think
though. I just thought it would be nice if they didn't appear, mainly because
there is no need to show empty quotes in the error message. Hmm, you have a
kimgr added a comment.
Why? It seems easier to me to map back if the diagnostic mirrors the code
as-written.
https://reviews.llvm.org/D39360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Rakete created this revision.
Rakete added a project: clang.
This patch removes the empty `""` when using `static_assert(1 + 1 == 3, "");`
in the diagnostic:
main.cpp:1:1: error: static_assert failed
static_assert(1 + 1 == 3, "");
^ ~~
https://reviews.llvm.org
