[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL317672: [clang-refactor] Introduce a new rename rule for qualified symbols (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D39332 Files: cfe/trunk/include/clang/Tooling/Refactorin

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

hokein updated this revision to Diff 122038. hokein marked 3 inline comments as done. hokein added a comment. Fix remaining nits. https://reviews.llvm.org/D39332 Files: include/clang/Tooling/Refactoring/Rename/RenamingAction.h lib/Tooling/Refactoring/RefactoringActions.cpp lib/Tooling/Ref

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

sammccall accepted this revision. sammccall added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:116 + /*Description=*/ + R"(Finds and renames qualified symbols in code with no indexer support. +It is used to move/rename a symbol to a new

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D39332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

hokein marked an inline comment as done. hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), +

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

hokein updated this revision to Diff 121941. hokein added a comment. - remove USRRenameRule - rebase to master https://reviews.llvm.org/D39332 Files: include/clang/Tooling/Refactoring/Rename/RenamingAction.h lib/Tooling/Refactoring/RefactoringActions.cpp lib/Tooling/Refactoring/Rename/Ren

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName));

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

sammccall added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName));

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName)); --

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

hokein updated this revision to Diff 121456. hokein marked an inline comment as done. hokein added a comment. Document the qualified rename. https://reviews.llvm.org/D39332 Files: include/clang/Tooling/Refactoring/Rename/RenamingAction.h lib/Tooling/Refactoring/RefactoringActions.cpp lib/

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName));

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName)); --

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName)); --