dcoughlin added a comment.
In https://reviews.llvm.org/D39220#907160, @george.karpenkov wrote:
> @dcoughlin OK, I'll commit that [I assuming not doing the review would be
> fine here]
Yes, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D39220
_
george.karpenkov added a comment.
@dcoughlin OK, I'll commit that [I assuming not doing the review would be fine
here]
Repository:
rL LLVM
https://reviews.llvm.org/D39220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
dcoughlin added a comment.
I agree with Alexander here. The LLVM naming convention is not going to change
and we should err on the side of using descriptive names. How about
"FunctionBodyFarm"?
Repository:
rL LLVM
https://reviews.llvm.org/D39220
__
george.karpenkov added inline comments.
Comment at: include/clang/Analysis/AnalysisDeclContext.h:424
/// methods during the analysis.
- BodyFarm *BdyFrm = nullptr;
+ std::unique_ptr BdyFrm;
alexfh wrote:
> george.karpenkov wrote:
> > alexfh wrote:
> > > Bd
alexfh added inline comments.
Comment at: include/clang/Analysis/AnalysisDeclContext.h:424
/// methods during the analysis.
- BodyFarm *BdyFrm = nullptr;
+ std::unique_ptr BdyFrm;
george.karpenkov wrote:
> alexfh wrote:
> > BdyFrm is somewhat cryptic. Mayb
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316536: [Analyzer] Store BodyFarm in std::unique_ptr
(authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39220?vs=120109&id=120151#toc
Repository:
rL LLVM
https://revi
george.karpenkov added inline comments.
Comment at: include/clang/Analysis/AnalysisDeclContext.h:424
/// methods during the analysis.
- BodyFarm *BdyFrm = nullptr;
+ std::unique_ptr BdyFrm;
alexfh wrote:
> BdyFrm is somewhat cryptic. Maybe Farm, Bodies or
alexfh added inline comments.
Comment at: include/clang/Analysis/AnalysisDeclContext.h:424
/// methods during the analysis.
- BodyFarm *BdyFrm = nullptr;
+ std::unique_ptr BdyFrm;
BdyFrm is somewhat cryptic. Maybe Farm, Bodies or something else that is no
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM.
https://reviews.llvm.org/D39220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lichray accepted this revision.
lichray added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
george.karpenkov updated this revision to Diff 120109.
https://reviews.llvm.org/D39220
Files:
include/clang/Analysis/AnalysisDeclContext.h
lib/Analysis/AnalysisDeclContext.cpp
Index: lib/Analysis/AnalysisDeclContext.cpp
===
---
lichray added inline comments.
Comment at: lib/Analysis/AnalysisDeclContext.cpp:606
-AnalysisDeclContextManager::~AnalysisDeclContextManager() {
- if (BdyFrm)
-delete BdyFrm;
-}
+AnalysisDeclContextManager::~AnalysisDeclContextManager() {}
Why having emp
george.karpenkov created this revision.
Herald added subscribers: szepet, kristof.beyls, xazax.hun, aemerson.
While by using `.get()` method we don't get the full protection offered by
`std::unique_ptr`, given that two bugs were already encountered
(http://lab.llvm.org:8011/builders/sanitizer-x8
13 matches
Mail list logo
