mstorsjo added a comment.
In https://reviews.llvm.org/D39206#904723, @compnerd wrote:
> I'd say out of range rather than too big.
Ok, pushing with the message changed to out of range, and actually printing the
value.
Repository:
rL LLVM
https://reviews.llvm.org/D39206
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316415: Add missing checks for register number (authored by
mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D39206?vs=119940&id=120001#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
compnerd accepted this revision.
compnerd added a comment.
I'd say out of range rather than too big.
https://reviews.llvm.org/D39206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D39206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo created this revision.
Herald added a subscriber: JDevlieghere.
Most other cases that touch `savedRegisters[reg]` have got this check, but
these three seemed to lack it.
https://reviews.llvm.org/D39206
Files:
src/DwarfParser.hpp
Index: src/DwarfParser.hpp
=