This revision was automatically updated to reflect the committed changes.
Closed by commit rL316571: [rename] support renaming class member. (authored by
hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D39178
Files:
cfe/trunk/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
cfe/trunk
ioeric accepted this revision.
ioeric added a comment.
Still lgtm.
https://reviews.llvm.org/D39178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added a comment.
I have refined the patch based on the https://reviews.llvm.org/D39241. Please
take another look.
https://reviews.llvm.org/D39178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
hokein updated this revision to Diff 120216.
hokein marked 2 inline comments as done.
hokein added a comment.
- remove the code of handling template class methods as it is fixed in another
patch.
- address review comments.
https://reviews.llvm.org/D39178
Files:
lib/Tooling/Refactoring/Rename
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lgtm. Nice!
Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:251
+ // Ignore implicit initializers.
+ if (!Initializer->isWritten())
+continue;
-
hokein created this revision.
Herald added subscribers: mgorny, klimek.
https://reviews.llvm.org/D39178
Files:
lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
unittests/Rename/CMakeLists.txt
unittests/Rename/RenameMemberTest.cpp
Index: unittests/Rename/RenameMemberTest.cpp
