[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-30 Thread Ivan Kosarev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316896: [CodeGen] Generate TBAA info for reference loads (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D39177?vs=120654&id=120800#toc Repository: rL LLVM https://reviews.l

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-29 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Looks good; sorry for not catching that, either. https://reviews.llvm.org/D39177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-27 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev updated this revision to Diff 120654. kosarev added a comment. - Fixed the type of the reference lvalue in loadToBegin(). John, can you please review the fix? Thanks. https://reviews.llvm.org/D39177 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGOpenMPRuntim

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-27 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1041 +else + BaseLV = CGF.EmitLoadOfReferenceLValue(BaseLV); BaseTy = BaseTy->getPointeeType(); Oh-oh, it looks I do something not functionally equivalent here. Sorry, will

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-26 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D39177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-26 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev updated this revision to Diff 120428. kosarev added a comment. - Referencee's renamed to pointee's. - EmitLoadOfReference() and EmitLoadOfReferenceLValue() reworked to take reference lvalues. https://reviews.llvm.org/D39177 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExpr.cpp l

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-23 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2171 + LValueBaseInfo *ReferenceeBaseInfo, + TBAAAccessInfo *ReferenceeTBAAInfo) { + llvm::LoadInst *Load = Builder.CreateLoad(ReferenceAddr

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-23 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev added inline comments. Comment at: test/CodeGen/tbaa-reference.cpp:1 // RUN: %clang_cc1 -triple x86_64-linux -O1 -disable-llvm-passes %s -emit-llvm -o - | FileCheck %s // Changes for this test look somewhat complicated, so here's a short summary: * We

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-23 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev created this revision. kosarev added a project: clang. Repository: rL LLVM https://reviews.llvm.org/D39177 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/CodeGenFunction.h test/CodeGen/tbaa-ref