[PATCH] D39127: Fix template parameter default args missed if redecled

2017-10-24 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In https://reviews.llvm.org/D39127#904685, @rnk wrote: > I think you forgot to svn add the test case Ugg... thanks for the heads up! Added in r316437 Repository: rL LLVM https://reviews.llvm.org/D39127 ___ cfe-comm

[PATCH] D39127: Fix template parameter default args missed if redecled

2017-10-23 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I think you forgot to svn add the test case Repository: rL LLVM https://reviews.llvm.org/D39127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39127: Fix template parameter default args missed if redecled

2017-10-23 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316405: Fix template parameter default args missed if redecled (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D39127?vs=119665&id=119991#toc Repository: rL LLVM https://

[PATCH] D39127: Fix template parameter default args missed if redecled

2017-10-23 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D39127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39127: Fix template parameter default args missed if redecled

2017-10-23 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:4811 + TemplateParameterList *Params = + cast(Template->getMostRecentDecl()) + ->getTemplateParameters(); erichkeane wrote: > mstorsjo wrote: > > erichkeane wrote: > > > mstorsjo

[PATCH] D39127: Fix template parameter default args missed if redecled

2017-10-22 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:4811 + TemplateParameterList *Params = + cast(Template->getMostRecentDecl()) + ->getTemplateParameters(); mstorsjo wrote: > erichkeane wrote: > > mstorsjo wrote: > > > How does

[PATCH] D39127: Fix template parameter default args missed if redecled

2017-10-22 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:4811 + TemplateParameterList *Params = + cast(Template->getMostRecentDecl()) + ->getTemplateParameters(); erichkeane wrote: > mstorsjo wrote: > > How does this work if there's an

[PATCH] D39127: Fix template parameter default args missed if redecled

2017-10-22 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:4811 + TemplateParameterList *Params = + cast(Template->getMostRecentDecl()) + ->getTemplateParameters(); mstorsjo wrote: > How does this work if there's another forward declar

[PATCH] D39127: Fix template parameter default args missed if redecled

2017-10-21 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:4808 + // Make sure we get the template parameter list from the most + // recentdeclaration, since that is the only one that has is guaranteed to + // have all the default template argument information.