[PATCH] D39080: [libcxx] [test] Tolerate even more [[nodiscard]] in the STL.

2017-11-06 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think I would prefer if this patch "left an explicit trace" as to the reasons for all the `(void)` casts. Specifically I think a macro like `TEST_IGNORE_DISCARD ` might be nice. @BillyONeal

[PATCH] D39080: [libcxx] [test] Tolerate even more [[nodiscard]] in the STL.

2017-10-18 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal created this revision. STL reviewed my [[nodiscard]] changes and suggested a ton more places. These are the associated test changes in libcxx. https://reviews.llvm.org/D39080 Files: test/std/algorithms/alg.nonmodifying/alg.search/search_n.pass.cpp test/std/algorithms/alg.nonmodi