arphaman added a comment.
In https://reviews.llvm.org/D39057#907820, @sammccall wrote:
> In https://reviews.llvm.org/D39057#906297, @ilya-biryukov wrote:
>
> > There's another patch (https://reviews.llvm.org/D39276) that tries to add
> > `workspace/executeCommand` for a slightly different use-ca
sammccall added a comment.
In https://reviews.llvm.org/D39057#906297, @ilya-biryukov wrote:
> There's another patch (https://reviews.llvm.org/D39276) that tries to add
> `workspace/executeCommand` for a slightly different use-case.
> Could we take the code for parsing/handling `workspace/execut
ilya-biryukov added a subscriber: malaperle.
ilya-biryukov added a comment.
There's another patch (https://reviews.llvm.org/D39276) that tries to add
`workspace/executeCommand` for a slightly different use-case.
Could we take the code for parsing/handling `workspace/executeCommand` from
this pat
sammccall added a comment.
As noted on the other patch, I'm not sure EditorCommands is a useful
abstraction.
This shows up one of the problems: clangd is mostly decoupled from the actual
behavior/semantics of the commands by the EditorCommands abstraction. However
LSP doesn't say what the stru
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:500
+if (!RefactoringClient)
+ RefactoringClient =
llvm::make_unique();
+Results = clangd::findAvailableRefactoringCommands(*RefactoringClient,
*AST,
Maybe initialize `Refacto
arphaman added a comment.
I think that the clangd editor plugin will have to be modified as well, but I
haven't looked into that yet.
Repository:
rL LLVM
https://reviews.llvm.org/D39057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
arphaman created this revision.
arphaman added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
This WIP patch provides a sample implementation of an integration of Clang's
refactoring actions from libToolingRefactor into clangd.
In terms of protocol support, the patch adds:
- S
