[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

2017-10-17 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316053: [CMake] Build Fuchsia toolchain as -O3 (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39017?vs=119372&id=119417#toc Repository: rL LLVM https://reviews.llvm.org/D39

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

2017-10-17 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. It seems like with the current patch, CMake already sets `-Wl,-O3` so that should be sufficient. Repository: rL LLVM https://reviews.llvm.org/D39017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

2017-10-17 Thread Rui Ueyama via Phabricator via cfe-commits
ruiu added a comment. Yes, specifically, lld does string tail merging (instead of regular string merging) when -O2 is given, so it would produce slightly smaller outputs. Repository: rL LLVM https://reviews.llvm.org/D39017 ___ cfe-commits mailin

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

2017-10-17 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Since we use lld, -Wl,-O2 also helps make the binaries smaller. Repository: rL LLVM https://reviews.llvm.org/D39017 ___ cfe-commits m

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

2017-10-17 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D39017 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsi