Hahnfeld removed a reviewer: Hahnfeld.
Hahnfeld added a comment.
Fixed differently in https://reviews.llvm.org/rL319657.
Repository:
rL LLVM
https://reviews.llvm.org/D39005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
hfinkel added a comment.
In https://reviews.llvm.org/D39005#900973, @jlebar wrote:
> > The first question that comes to mind is what is the link between data
> > layout and name mangling conventions?
>
> I pulled up http://llvm.org/doxygen/classllvm_1_1DataLayout.html and searched
> for "mangli
jlebar added a comment.
> The first question that comes to mind is what is the link between data layout
> and name mangling conventions?
I pulled up http://llvm.org/doxygen/classllvm_1_1DataLayout.html and searched
for "mangling" -- presumably this is what they were referring to. We also
don'
gtbercea added a comment.
In https://reviews.llvm.org/D39005#900226, @jlebar wrote:
> > I'd be interested to get the ball rolling in regard to coming up with a fix
> > for this. I see some suggestions in past patches. Some help/clarification
> > would be much appreciated.
>
> Happy to help, but
jlebar added a comment.
> I'd be interested to get the ball rolling in regard to coming up with a fix
> for this. I see some suggestions in past patches. Some help/clarification
> would be much appreciated.
Happy to help, but I'm not sure what to offer beyond the link in Art's previous
comment
gtbercea added a comment.
Hi Artem, Justin,
I see that this patch is the same as the patch Arpith wanted to post a while
back i.e. https://reviews.llvm.org/D17738.
Was there a consensus regarding what the right thing to do is in this case?
I'd be interested to get the ball rolling in regard to
tra requested changes to this revision.
tra added a comment.
Justin is right. I completely forgot about this. :-/
Hal offered possible solution: https://reviews.llvm.org/D17738#661115
Repository:
rL LLVM
https://reviews.llvm.org/D39005
___
cfe-co
jlebar added a comment.
This has been tried twice before, see https://reviews.llvm.org/D29883 and
https://reviews.llvm.org/D17738. I'm as unhappy about this as anyone, and
personally I don't have any preference about how we try to solve it. But I
think we shouldn't check this in without heari
gtbercea created this revision.
Herald added a subscriber: jholewinski.
Clean-up variable and function names.
Repository:
rL LLVM
https://reviews.llvm.org/D39005
Files:
lib/Target/NVPTX/NVPTXAssignValidGlobalNames.cpp
Index: lib/Target/NVPTX/NVPTXAssignValidGlobalNames.cpp
==
