[PATCH] D38989: [clang-rename] Rename enum.

2017-10-17 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315999: [clang-rename] Rename enum. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D38989 Files: cfe/trunk/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp cfe/trunk/unittests/Re

[PATCH] D38989: [clang-rename] Rename enum.

2017-10-17 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:212 + // Ignore the case where there is no prefix qualifer for the enum constant + // expression lik

[PATCH] D38989: [clang-rename] Rename enum.

2017-10-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:212 + // Ignore the case where there is no prefix qualifer for the enum constant + // expression like `a = Green`. + if (!Expr->hasQualifier()) ioeric wrote:

[PATCH] D38989: [clang-rename] Rename enum.

2017-10-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 119309. hokein added a comment. Use getQualifierLoc. https://reviews.llvm.org/D38989 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/CMakeLists.txt unittests/Rename/RenameEnumTest.cpp Index: unittests/Rename/RenameEnumTest.cpp

[PATCH] D38989: [clang-rename] Rename enum.

2017-10-17 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:212 + // Ignore the case where there is no prefix qualifer for the enum constant + // expression like `a = Green`. + if (!Expr->hasQualifier()) hokein wrote:

[PATCH] D38989: [clang-rename] Rename enum.

2017-10-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:212 + // Ignore the case where there is no prefix qualifer for the enum constant + // expression like `a = Green`. + if (!Expr->hasQualifier()) ioeric wrote:

[PATCH] D38989: [clang-rename] Rename enum.

2017-10-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 119274. hokein marked 2 inline comments as done. hokein added a comment. address review comments, and add FIXME https://reviews.llvm.org/D38989 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/CMakeLists.txt unittests/Rename/Rena

[PATCH] D38989: [clang-rename] Rename enum.

2017-10-17 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:212 + // Ignore the case where there is no prefix qualifer for the enum constant + // expression like `a = Green`. + if (!Expr->hasQualifier()) Why do we ign

[PATCH] D38989: [clang-rename] Rename enum.

2017-10-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. Herald added subscribers: mgorny, klimek. - Add unit tests for renaming enum. - Support unscoped enum constants in expressions. https://reviews.llvm.org/D38989 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/CMakeLists.txt unittests/Re