[PATCH] D38979: Fix usage in TableGen of getValueAsString

2017-10-16 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315956: Fix usage in TableGen of getValueAsString (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38979?vs=119218&id=119227#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D38979: Fix usage in TableGen of getValueAsString

2017-10-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the cleanup! https://reviews.llvm.org/D38979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D38979: Fix usage in TableGen of getValueAsString

2017-10-16 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. Record::getValueAsString returns a stringref to an interned string (apparently had been changed since most of tablegen was written). In this patch, I audited the usage of getValueAsString to find places where we can trivially stop storing 'std::string' and instea