This revision was automatically updated to reflect the committed changes.
Closed by commit rL315786: [ubsan] Don't emit function signatures for
non-static member functions (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D38913?vs=118999&id=119004#toc
Repository:
rL L
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Small nit on the first line of the commit message: it should probably mention
non-static member functions, rather than virtual methods.
https://reviews.llvm.org/D38913
vsk created this revision.
The function sanitizer only checks indirect calls through function
pointers. This excludes all non-static member functions (constructor
calls, calls through thunks, etc all use a separate code path). Don't
emit function signatures for functions that won't be checked.
Ap
