[PATCH] D38903: [ubsan] Only use indirect RTTI in prologues on Darwin

2017-10-13 Thread Vedant Kumar via Phabricator via cfe-commits
vsk abandoned this revision. vsk added a comment. https://reviews.llvm.org/D38913 should make this unnecessary. https://reviews.llvm.org/D38903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D38903: [ubsan] Only use indirect RTTI in prologues on Darwin

2017-10-13 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. @pcc made an alternate suggestion which led to https://reviews.llvm.org/D38913. We're still discussing whether the new patch is a sufficient fix. https://reviews.llvm.org/D38903 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D38903: [ubsan] Only use indirect RTTI in prologues on Darwin

2017-10-13 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. Sounds good. This doesn't seem too controversial, since it just takes us back to the old behavior on all platforms except Darwin. I'll wait an hour or so before committing in case there are any more comments. https://reviews.llvm.org/D38903 _

[PATCH] D38903: [ubsan] Only use indirect RTTI in prologues on Darwin

2017-10-13 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. Given you were the last one in this code it seems reasonable to let you go for it :) That said, I didn't notice anything in particular that stuck out at me. https://reviews.llvm.org/D38903 ___ cfe-commits mailing list cfe

[PATCH] D38903: [ubsan] Only use indirect RTTI in prologues on Darwin

2017-10-13 Thread Vedant Kumar via Phabricator via cfe-commits
vsk created this revision. Using a layer of indirection to point to RTTI through function prologues is not supported on some setups. One reported error message is: error: Cannot represent a difference across sections This is a regression. This patch limits the indirect RTTI behavior to Darwin,