This revision was automatically updated to reflect the committed changes.
Closed by commit rL315902: [CUDA] Require libdevice only if needed (authored by
Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D38901?vs=118969&id=119149#toc
Repository:
rL LLVM
https://reviews.llvm.org/
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you.
https://reviews.llvm.org/D38901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Hahnfeld updated this revision to Diff 118969.
Hahnfeld added a comment.
Fix one more condition that checks for `nvvm/libdevice` and add a test.
https://reviews.llvm.org/D38901
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/CUDA-nolibdevice/usr/local/cuda/bin/.keep
test/Driver/I
tra added a comment.
The change could use a test.
https://reviews.llvm.org/D38901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld created this revision.
If the user passes -nocudalib, we can live without it being present.
Simplify the code by just checking whether LibDeviceMap is empty.
https://reviews.llvm.org/D38901
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp