This revision was automatically updated to reflect the committed changes.
Closed by commit rL315996: [CMake][OpenMP] Customize default offloading arch
(authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D38883?vs=118961&id=119310#toc
Repository:
rL LLVM
https://reviews
gtbercea added a comment.
LGTM
https://reviews.llvm.org/D38883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.h:90
- }
};
gtbercea wrote:
> gtbercea wrote:
> > tra wrote:
> > > gtbercea wrote:
> > > > gtbercea wrote:
> > > > > I would also like to keep the spirit of this code if not in this
> > > > >
Hahnfeld updated this revision to Diff 118961.
Hahnfeld marked an inline comment as done.
Hahnfeld edited the summary of this revision.
Hahnfeld added a comment.
Check that the user didn't specify a value lower than `sm_30` and re-add some
code as discussed.
https://reviews.llvm.org/D38883
Fil
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.h:90
- }
};
gtbercea wrote:
> tra wrote:
> > gtbercea wrote:
> > > gtbercea wrote:
> > > > I would also like to keep the spirit of this code if not in this exact
> > > > form at least som
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.h:90
- }
};
tra wrote:
> gtbercea wrote:
> > gtbercea wrote:
> > > I would also like to keep the spirit of this code if not in this exact
> > > form at least something that performs the s
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.h:90
- }
};
gtbercea wrote:
> gtbercea wrote:
> > I would also like to keep the spirit of this code if not in this exact form
> > at least something that performs the same functionality.
> @tr
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.h:90
- }
};
gtbercea wrote:
> I would also like to keep the spirit of this code if not in this exact form
> at least something that performs the same functionality.
@tra what's your opini
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-for (auto key : LibDeviceMap.keys()) {
-
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-for (auto key : LibDeviceMap.keys()) {
-
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-for (auto key : LibDeviceMap.keys()) {
-
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-for (auto key : LibDeviceMap.keys()) {
-
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.h:90
- }
};
I would also like to keep the spirit of this code if not in this exact form at
least something that performs the same functionality.
https://reviews.llvm.org/D38883
_
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-for (auto key : LibDeviceMap.keys()) {
-
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-for (auto key : LibDeviceMap.keys()) {
-
Hahnfeld marked 4 inline comments as done.
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-for (auto key : LibDeviceMap.keys()) {
-
Hahnfeld marked an inline comment as done.
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:170-182
-// This code prevents IsValid from being set when
-// no libdevice has been found.
-bool allEmpty = true;
-std::string LibDeviceFile;
-for (auto key : LibDeviceMap.keys()) {
-
Hahnfeld created this revision.
Herald added a subscriber: mgorny.
For the shuffle instructions in reductions we need at least sm_30
but the user may want to customize the default architecture.
Also remove some code that went in while troubleshooting broken
tests on external build bots.
https://
20 matches
Mail list logo
