vsk abandoned this revision.
vsk added a comment.
Abandoned in favor of a proper fix: https://reviews.llvm.org/D41149
https://reviews.llvm.org/D38861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
vsk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+ }
+}
+
joerg wrote:
> vsk wrote:
> > rjmccall wrote:
> > > Is there a reason this only fails on x86? If LLVM doesn't have generic
> > > wide-operation lowering, this probably needs
joerg added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+ }
+}
+
vsk wrote:
> rjmccall wrote:
> > Is there a reason this only fails on x86? If LLVM doesn't have generic
> > wide-operation lowering, this probably needs to be a target whi
vsk added a comment.
In https://reviews.llvm.org/D38861#896435, @rjmccall wrote:
> Okay. Sounds good to me.
>
> We intend to actually implement the generic lowering, I hope?
Yes, I'll make a note of that in PR34920, and am tracking the bug internally in
rdar://problem/34963321.
https://revi
rjmccall added a comment.
Okay. Sounds good to me.
We intend to actually implement the generic lowering, I hope?
https://reviews.llvm.org/D38861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
vsk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+ }
+}
+
rjmccall wrote:
> Is there a reason this only fails on x86? If LLVM doesn't have generic
> wide-operation lowering, this probably needs to be a target whitelist rather
> th
vsk updated this revision to Diff 118857.
vsk added a comment.
Herald added a subscriber: aheejin.
- Update to check against a whitelist of supported targets.
https://reviews.llvm.org/D38861
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-overflow-unsupported.c
test/CodeGen/builtin
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2263
+ }
+}
+
Is there a reason this only fails on x86? If LLVM doesn't have generic
wide-operation lowering, this probably needs to be a target whitelist rather
than a blacklist.
vsk created this revision.
LLVM's smul.with.overflow intrinsic isn't supported on X86 for bit
widths larger than 64, or on X86-64 for bit widths larger than 128.
The failure mode is either a linker error ("the __muloti4 builtin isn't
available for this target") or an assertion failure ("Selection
