This revision was automatically updated to reflect the committed changes.
Closed by commit rL315607: [X86] Add CLWB intrinsic. clang part (authored by
ctopper).
Changed prior to commit:
https://reviews.llvm.org/D38781?vs=118816&id=118822#toc
Repository:
rL LLVM
https://reviews.llvm.org/D387
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM - one minor
Comment at: lib/Headers/clwbintrin.h:42
+///
+/// \param __p
+///A pointer to the memory location used to identify the cache line to be
---
craig.topper updated this revision to Diff 118816.
craig.topper added a comment.
Address review feedback
https://reviews.llvm.org/D38781
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/CMakeLists.txt
lib/Headers/clwbintrin.h
lib/Headers/immintrin.h
test/CodeGen/builtin-clwb.c
RKSimon added inline comments.
Comment at: lib/Headers/clwbintrin.h:34
+
+static __inline__ void __DEFAULT_FN_ATTRS
+_mm_clwb(void const *__m) {
Worth adding the doxygen description? You can probably just copy+paste+modify
the _mm_clflush documentation.
==
