vsk abandoned this revision.
vsk added a comment.
For those following along, Alex worked out that this doesn't affect apple-clang
802. We took a closer look and found that the build break just affects
clang-900, and was introduced in this r290889. The fix (r293167) didn't make it
into clang-900
arphaman added inline comments.
Comment at: include/__threading_support:26
+#if (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) &&
(__MAC_OS_X_VERSION_MIN_REQUIRED < 101300)) \
+|| (defined(__IPHONE_OS_VERSION_MIN_REQUIRED) &&
(__IPHONE_OS_VERSION_MIN_REQUIRED < 11)) \
vsk added a comment.
I'm not sure how to test the warning against anything but the macOS SDK. When I
tried, I hit a -Wincompatible-sysroot issue. I can leave those changes out of
this patch if we want to be more conservative.
https://reviews.llvm.org/D38567
_
vsk created this revision.
Prior to macOS 10.13 and iOS 11, defining POSIX_C_SOURCE before
including resulted in hard-to-understand errors. That
definition causes a bunch of important definitions from the system
headers to be skipped, so users see failures like "can't find
mach_port_t".
This pat
