This revision was automatically updated to reflect the committed changes.
Closed by commit rL316246: [clang-tidy] Don't error on MS-style inline
assembly. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D38549?vs=119677&id=119722#toc
Repository:
rL LLVM
https://revi
alexfh added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/hicpp-no-assembler.cpp:13-16
+ _asm {
+mov al, 2;
+// CHECK-MESSAGES: :[[@LINE-2]]:3: warning: do not use inline assembler in
safety-critical code [hicpp-no-assembler]
+ }
alex
alexfh added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/hicpp-no-assembler.cpp:13-16
+ _asm {
+mov al, 2;
+// CHECK-MESSAGES: :[[@LINE-2]]:3: warning: do not use inline assembler in
safety-critical code [hicpp-no-assembler]
+ }
Will
zturner updated this revision to Diff 119677.
zturner added a comment.
Added a test. Alex, if you can confirm this test gives sufficient coverage I
can go ahead and submit today. Thanks!
https://reviews.llvm.org/D38549
Files:
clang-tools-extra/clang-tidy/CMakeLists.txt
clang-tools-extra/
alexfh added a comment.
Zachary, do you plan to commit this? I'd also suggest adding a regression test.
Thanks!
https://reviews.llvm.org/D38549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
The first attempt to fix this (https://reviews.llvm.org/D17981) was stuck on
figuring out whether we care about the binary size. It seems to me that the
binary size is secondary to maintaining
zturner created this revision.
Herald added subscribers: xazax.hun, mgorny.
Currently clang-tidy fails on any file that includes inline assembly. This is
not a great out-of-the-box experience since many system headers include inline
assembly, particularly on Windows.
I checked through the vari
