[PATCH] D38380: [libunwind] Add CMake support for building for MinGW

2017-10-02 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314716: Add CMake support for building for MinGW (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D38380?vs=117046&id=117417#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D38380: [libunwind] Add CMake support for building for MinGW

2017-09-28 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: cmake/config-ix.cmake:38 +else () + set(MINGW_RUNTIME gcc_s gcc) +endif() compnerd wrote: > This seems really weird. `gcc_s` and `gcc` are the same library, the former > is the shared version of the latte

[PATCH] D38380: [libunwind] Add CMake support for building for MinGW

2017-09-28 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. With an explanation of the `gcc_s` vs `gcc`, I think this LG. Comment at: cmake/config-ix.cmake:38 +else () + set(MINGW_RUNTIME gcc_s gcc) +endif() This seems really weird. `gcc_s` and `gcc` are the same library, the form

[PATCH] D38380: [libunwind] Add CMake support for building for MinGW

2017-09-28 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. Herald added a subscriber: mgorny. This is the cmake specific parts of https://reviews.llvm.org/D33601 (by Martell Malone) split out into a separate patch, to ease getting this part reviewed indendent of the rest of that patch. https://reviews.llvm.org/D38380 F