[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-10-15 Thread Martell Malone via Phabricator via cfe-commits
martell added inline comments. Comment at: cfe/trunk/test/Driver/cl-options.c:524 +// RUN: %clang_cl -fmsc-version=1900 -TP -std:c++17 -### -- %s 2>&1 | FileCheck -check-prefix=STDCXX17 %s +// STDCXX14: -std=c++17 + This was incorrect, it should have been `STDCX

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-10-15 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. Landed, @rnk I missed this message in my travels from Ireland back to Mountain View. Just catching up with everything now :) Repository: rL LLVM https://reviews.llvm.org/D38123 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-10-15 Thread Martell Malone via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315864: [driver] [cl] Add/fix c++17/c++latest (authored by martell). Changed prior to commit: https://reviews.llvm.org/D38123?vs=116154&id=119086#toc Repository: rL LLVM https://reviews.llvm.org/D38

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-10-03 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. Sorry for the delay, thank you, this looks good! @martell, do you mind landing this? https://reviews.llvm.org/D38123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread Martell Malone via Phabricator via cfe-commits
martell accepted this revision. martell added a comment. This revision is now accepted and ready to land. It seems that msvc enabled some c++17 features when in c++14 mode and they left them enabled because projects became dependant on them. switching to c++17 as the default and removing the c++1

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread daxpedda via Phabricator via cfe-commits
daxpedda added a comment. According to this the default is still c++14. I do not have commit access, I would prefer if somebody else commits this in my stead. Comment at: test/Driver

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. LGTM we should probably set c++17 as the default over c++14 as part of this change. given that everything seems in order for c++17 bar P0522R0 so this looks like the change should be good. adding @rnk to confirm. @daxpedda do you have commit access?

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread daxpedda via Phabricator via cfe-commits
daxpedda updated this revision to Diff 116154. daxpedda added a comment. Discovered that these flags were tested and added new test. https://reviews.llvm.org/D38123 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c Index: test/Driver/cl-options.c

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread daxpedda via Phabricator via cfe-commits
daxpedda created this revision. Current "/std:c++latest" adds "-std=c++17", VS has it's own "/std:c++17" for that now. This is my first commit by the way, please tell me if there is anything I can do to improve. Thanks. https://reviews.llvm.org/D38123 Files: lib/Driver/ToolChains/Clang.cpp