[PATCH] D38092: [MS Compat]Allow __interfaces to have properties.

2017-09-20 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313828: [MS Compat]Allow __interfaces to have properties. (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38092?vs=116046&id=116097#toc Repository: rL LLVM https://revie

[PATCH] D38092: [MS Compat]Allow __interfaces to have properties.

2017-09-20 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Sema/SemaDeclCXX.cpp:2871 + InvalidDecl = + (DS.getStorageClassSpec() == DeclSpec::SCS_typedef || MSPropertyAttr) + ? 0

[PATCH] D38092: [MS Compat]Allow __interfaces to have properties.

2017-09-20 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:2871 + InvalidDecl = + (DS.getStorageClassSpec() == DeclSpec::SCS_typedef || MSPropertyAttr) + ? 0 Note: Clang format did this craziness... I'm open to whatever form

[PATCH] D38092: [MS Compat]Allow __interfaces to have properties.

2017-09-20 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. __interface types are allowed in MSVC to have "property" data members (marked with declspec property). This patch alters Sema to allow property data members. https://reviews.llvm.org/D38092 Files: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/ms-interface.cpp In