This revision was automatically updated to reflect the committed changes.
Closed by commit rL314445: [clangd] Skip informative qualifier chunks.
(authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D38083
Files:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
clang-tools-ex
rwols accepted this revision.
rwols added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ilya-biryukov updated this revision to Diff 116297.
ilya-biryukov added a comment.
- Fixed CHECK-DAG typo.
https://reviews.llvm.org/D38083
Files:
clangd/ClangdUnit.cpp
test/clangd/completion-qualifiers.test
Index: test/clangd/completion-qualifiers.test
ilya-biryukov added inline comments.
Comment at: test/clangd/completion-qualifiers.test:12
+# CHECK: {"jsonrpc":"2.0","id":2,"result":[
+# CHEKC-DAG: {"label":"foo()
const","kind":2,"detail":"int","sortText":"00035foo","filterText":"foo","insertText":"foo","insertTextFormat":1}
rwols added inline comments.
Comment at: test/clangd/completion-qualifiers.test:12
+# CHECK: {"jsonrpc":"2.0","id":2,"result":[
+# CHEKC-DAG: {"label":"foo()
const","kind":2,"detail":"int","sortText":"00035foo","filterText":"foo","insertText":"foo","insertTextFormat":1}
+# CHEKC
ilya-biryukov created this revision.
Completion results look much nicer without them.
Informative qualifiers are stored for every method from a base class, even when
calling those methods does not require any qualifiers. For example,
struct Foo { int foo(); };
struct Bar : Foo { };
void tes
