This revision was automatically updated to reflect the committed changes.
Closed by commit rL314019: Set completion priority of destructors and operators
to CCP_Unlikely. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D38081
Files:
cfe/trunk/lib/Sema/SemaCodeComplete.
ilya-biryukov added a comment.
Thanks for the review!
Sorry for inappropriate ping, I'll make sure to stick to the policy.
https://reviews.llvm.org/D38081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
ilya-biryukov updated this revision to Diff 116381.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Removed redundant NameKind:: qualifiers.
https://reviews.llvm.org/D38081
Files:
lib/Sema/SemaCodeComplete.cpp
test/Index/complete-access-checks.cpp
test/Ind
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Nice, LGTM
Please keep in mind that LLVM follows a weekly ping rate:
https://llvm.org/docs/DeveloperPolicy.html#code-reviews .
Comment at: lib/Sema/SemaCodeComplete.cpp
ilya-biryukov added a comment.
Friendly ping. Any suggestions for other reviewers are also very welcome.
https://reviews.llvm.org/D38081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
krasimir added a comment.
+1! I totally agree with this!
https://reviews.llvm.org/D38081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov created this revision.
Herald added a subscriber: eraman.
It will move destructors and operators to the end of completion list.
Destructors and operators are currently very high on the completion
list, as they have the same priority as member functions. However,
they are clearly not
