This revision was automatically updated to reflect the committed changes.
Closed by commit rL313831: [MSan] Disable sanitization for
__sanitizer_dtor_callback. (authored by morehouse).
Changed prior to commit:
https://reviews.llvm.org/D38063?vs=116100&id=116103#toc
Repository:
rL LLVM
https
morehouse updated this revision to Diff 116100.
morehouse added a comment.
- Add LLVM test.
https://reviews.llvm.org/D38063
Files:
clang/lib/CodeGen/CGClass.cpp
clang/test/CodeGenCXX/sanitize-dtor-callback.cpp
llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
llvm/test/Instrumenta
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
Please also add a tiny LLVM test that call instructions with nosanitize
metadata are not instrumented.
https://reviews.llvm.org/D38063
___
cfe
morehouse updated this revision to Diff 116072.
morehouse added a comment.
- Add test case.
- Use SanitizerScope.
https://reviews.llvm.org/D38063
Files:
clang/lib/CodeGen/CGClass.cpp
clang/test/CodeGenCXX/sanitize-dtor-callback.cpp
llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
eugenis added a comment.
A test, please.
Comment at: clang/lib/CodeGen/CGClass.cpp:1592
+ llvm::CallInst *I = CGF.EmitNounwindRuntimeCall(Fn, Args);
+ I->setMetadata("nosanitize", llvm::MDNode::get(CGF.getLLVMContext(),
+ llv
morehouse created this revision.
Herald added a subscriber: hiraditya.
Eliminate unnecessary instrumentation at __sanitizer_dtor_callback
call sites. Fixes https://github.com/google/sanitizers/issues/861.
https://reviews.llvm.org/D38063
Files:
clang/lib/CodeGen/CGClass.cpp
llvm/lib/Transfo