gtbercea updated this revision to Diff 116747.
gtbercea added a comment.
Fix test.
https://reviews.llvm.org/D38040
Files:
test/OpenMP/openmp_offload_codegen.cpp
Index: test/OpenMP/openmp_offload_codegen.cpp
===
--- /dev/null
++
gtbercea reopened this revision.
gtbercea added a comment.
This revision is now accepted and ready to land.
Open
https://reviews.llvm.org/D38040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
gtbercea updated this revision to Diff 116671.
gtbercea added a comment.
Add nocudalib flag.
https://reviews.llvm.org/D38040
Files:
test/OpenMP/target_map_codegen.cpp
Index: test/OpenMP/target_map_codegen.cpp
===
--- test/OpenM
gtbercea reopened this revision.
gtbercea added a comment.
This revision is now accepted and ready to land.
Open
https://reviews.llvm.org/D38040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
gtbercea updated this revision to Diff 116664.
gtbercea added a comment.
Fix test.
https://reviews.llvm.org/D38040
Files:
test/OpenMP/target_map_codegen.cpp
Index: test/OpenMP/target_map_codegen.cpp
===
--- test/OpenMP/target_m
gtbercea added a comment.
In https://reviews.llvm.org/D38040#878799, @Hahnfeld wrote:
> In https://reviews.llvm.org/D38040#878441, @gtbercea wrote:
>
> > The test is verifying whether the parameter is passed to the kernel
> > correctly. I believe it was not passed as a reference before the patch
Hahnfeld added a comment.
In https://reviews.llvm.org/D38040#878441, @gtbercea wrote:
> The test is verifying whether the parameter is passed to the kernel
> correctly. I believe it was not passed as a reference before the patch.
Ah, right: This isn't checked anywhere before. Maybe add a comme
gtbercea added a comment.
In https://reviews.llvm.org/D38040#878090, @Hahnfeld wrote:
> Hi Doru,
>
> if I remember correctly I submitted https://reviews.llvm.org/D34888 for a
> crash when mapping a scalar value with nested regions.
> I've marked another test in this file that the codegen for `t
Hahnfeld added a comment.
Hi Doru,
if I remember correctly I submitted https://reviews.llvm.org/D34888 for a crash
when mapping a scalar value with nested regions.
I've marked another test in this file that the codegen for `tofrom` is correct.
So I don't know if this test checks some other cond
tra added inline comments.
Comment at: test/OpenMP/target_map_codegen.cpp:4845
+///==///
+// RUN: %clang_cc1 -DCK30 -std=c++11 -fopenmp -S -emit-llvm -fopenmp
-fopenmp-targets=nvptx64-nvidia-cuda %s -o - 2>&
gtbercea updated this revision to Diff 115947.
Repository:
rL LLVM
https://reviews.llvm.org/D38040
Files:
test/OpenMP/target_map_codegen.cpp
Index: test/OpenMP/target_map_codegen.cpp
===
--- test/OpenMP/target_map_codegen.cpp
tra added a comment.
LGTM in general.
Comment at: test/OpenMP/target_map_codegen.cpp:4845
+///==///
+// RUN: %clang_cc1 -DCK30 -std=c++11 -fopenmp -S -emit-llvm -fopenmp
-fopenmp-targets=nvptx64-nvidia-cud
gtbercea created this revision.
Test for checking if the mapping is performed correctly. This is a test
initially included in Patch https://reviews.llvm.org/D29905
Repository:
rL LLVM
https://reviews.llvm.org/D38040
Files:
test/OpenMP/target_map_codegen.cpp
Index: test/OpenMP/target_map
14 matches
Mail list logo