This revision was automatically updated to reflect the committed changes.
Closed by commit rL313866: [analyzer] Fix an assertion fail in
VirtualCallChecker (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D37978?vs=115656&id=116145#toc
Repository:
rL LLVM
https://revie
alexfh added a comment.
Actually, after looking at the getBestDynamicClassType() implementation, I'm
pretty sure it does all things IgnoreImpCasts() used to do that are relevant to
the use case. So the patch seems to be trivially correct. Other reviewers'
comments (if any) can be addressed post
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks reasonable, but please wait for someone who actually knows this code.
Repository:
rL LLVM
https://reviews.llvm.org/D37978
___
cfe-commit
xazax.hun created this revision.
Herald added subscribers: baloghadamsoftware, whisperity.
This patch attempts to fix PR34451.
The `getBestDynamicClassType` call can only handle `RecordDecls` and pointers
to `RecordDecls`. The code removed all the implicit casts, this includes the
array to poin
