mclow.lists closed this revision.
mclow.lists added a comment.
Landed as revision 316095.
https://reviews.llvm.org/D37955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
All the tests pass now (on Mac OS) Thanks!
https://reviews.llvm.org/D37955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
timshen updated this revision to Diff 115851.
timshen added a comment.
Fixed.
Those tests were XFAILing on linux-gnu. I also created
https://reviews.llvm.org/D38041 to XFAIL only on the failing ones.
https://reviews.llvm.org/D37955
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.
mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.
When I applied this patch locally, some of the other tests started failing.
Specifically:
Assertion failed: (!std::regex_match(s, m, std::regex("^[a-f]$",
std::regex_cons
timshen updated this revision to Diff 115554.
timshen added a comment.
Remove "#include " in the test. It was for debugging.
https://reviews.llvm.org/D37955
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.search/invert_neg_word_search.pass.cpp
Index: libcxx/test/std/re/re.alg
timshen created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
Ideally we want !(neg_mask || neg_char), aka (!neg_mask && !neg_char). Before
the change, the code is (!neg_mask || !neg_char).
This fixes PR34310.
https://reviews.llvm.org/D37955
Files:
libcx
