[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-27 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314364: [Preprocessor] Preserve #pragma clang assume_nonnull in preprocessed output (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D37861?vs=115838&id=116903#toc Repository:

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-27 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Oops, sorry, lost track of it; I'll commit it today. https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-27 Thread Zbigniew Sarbinowski via Phabricator via cfe-commits
zibi added a comment. Eli, if you have trouble committing this please let me know. Not sure what is happening. https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-22 Thread Zbigniew Sarbinowski via Phabricator via cfe-commits
zibi added a comment. Yes, please do the commit, thank you. In https://reviews.llvm.org/D37861#878194, @efriedma wrote: > LGTM. > > Do you want me to commit this for you? https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. Do you want me to commit this for you? https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-21 Thread Zbigniew Sarbinowski via Phabricator via cfe-commits
zibi added a comment. ping https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-19 Thread Zbigniew Sarbinowski via Phabricator via cfe-commits
zibi added a comment. Please be aware that I don't have the commit permission yet since this is my first patch. I will rely on somebody to push it to the trunk. https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-19 Thread Zbigniew Sarbinowski via Phabricator via cfe-commits
zibi updated this revision to Diff 115838. zibi added a comment. original + review changes https://reviews.llvm.org/D37861 Files: include/clang/Lex/PPCallbacks.h lib/Frontend/PrintPreprocessedOutput.cpp lib/Lex/Pragma.cpp test/Preprocessor/pragma_assume_nonnull.c Index: test/Preprocess

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-18 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. It looks like you uploaded a diff against the previous version of the patch instead of trunk? https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-18 Thread Zbigniew Sarbinowski via Phabricator via cfe-commits
zibi marked 2 inline comments as done. zibi added a comment. Good catch, thank you. I submitted a new patch. https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-18 Thread Zbigniew Sarbinowski via Phabricator via cfe-commits
zibi updated this revision to Diff 115643. zibi added a comment. Addressing the review. https://reviews.llvm.org/D37861 Files: lib/Frontend/PrintPreprocessedOutput.cpp test/Preprocessor/pragma_assume_nonnull.c Index: test/Preprocessor/pragma_assume_nonnull.c ==

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-15 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: lib/Frontend/PrintPreprocessedOutput.cpp:566 + MoveToLine(Loc); + OS << "#pragma " << "clang assume_nonnull end"; + setEmittedDirectiveOnThisLine(); Extra "<<"? Comment at: test/Preprocessor/pragma

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

2017-09-14 Thread Zbigniew Sarbinowski via Phabricator via cfe-commits
zibi created this revision. Herald added subscribers: kbarton, nemanjai. When #pragma clang assume_nonnull begin || end is present in the source it is completely gone from pre-processed output when compiled with -E or -P. This patch make sure the pragma is preserved. I included 1 test case which