This revision was automatically updated to reflect the committed changes.
Closed by commit rCRT31: [MSan] Enable use-after-dtor instrumentation by
default. (authored by morehouse, committed by ).
Herald added a subscriber: Sanitizers.
Changed prior to commit:
https://reviews.llvm.org/D37860
morehouse added a comment.
PTAL. Patch has been updated.
https://reviews.llvm.org/D37860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
morehouse updated this revision to Diff 129318.
morehouse added a comment.
- Enable use-after-dtor instrumentation by default.
- Make sanitize-no-dtor-callback.cpp test fail with UAD instrumentation.
- Update test cases to reflect new default.
https://reviews.llvm.org/D37860
Files:
clang/incl
morehouse added a comment.
Patch is out-of-date. But the flag has been enabled internally for over a
month with no issues. I'll update this patch soon, so we can flip the default
here.
https://reviews.llvm.org/D37860
___
cfe-commits mailing list
vitalybuka added a comment.
What is the status of this patch?
https://reviews.llvm.org/D37860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
morehouse added a comment.
In https://reviews.llvm.org/D37860#871368, @eugenis wrote:
> Looking at __sanitizer_dtor_callback implementation, this change will add a
> (fast) stack unwind in every destructor. In extreme cases (like a tight loop
> doing string operations) it could be bad for perfo
morehouse updated this revision to Diff 115312.
morehouse edited the summary of this revision.
morehouse added a comment.
- Move the new flag to https://reviews.llvm.org/D37867
- Address Vitaly's comments.
https://reviews.llvm.org/D37860
Files:
clang/lib/Driver/SanitizerArgs.cpp
clang/test/
eugenis added a comment.
Looking at __sanitizer_dtor_callback implementation, this change will add a
(fast) stack unwind in every destructor. In extreme cases (like a tight loop
doing string operations) it could be bad for performance. I've seen ~15% AFAIR.
https://reviews.llvm.org/D37860
_
vitalybuka added inline comments.
Comment at: compiler-rt/test/msan/use-after-dtor.cc:13
#include
#include
morehouse wrote:
> vitalybuka wrote:
> > Probably we need one test which check that we stop detecting bugs with
> > -fno-sanitize-memory-track-origin
morehouse added inline comments.
Comment at: clang/include/clang/Driver/Options.td:854
HelpText<"Enable use-after-destroy
detection in MemorySanitizer">;
+def fno_sanitize_memory_use_after_dtor : Flag<["-"],
"fno-sanitize-memory-use-after-d
vitalybuka requested changes to this revision.
vitalybuka added inline comments.
This revision now requires changes to proceed.
Comment at: clang/test/Driver/fsanitize.c:175
-// RUN: %clang -target x86_64-linux-gnu -fsanitize=memory
-fsanitize-memory-use-after-dtor -pie %s -##
vitalybuka added inline comments.
Comment at: clang/include/clang/Driver/Options.td:854
HelpText<"Enable use-after-destroy
detection in MemorySanitizer">;
+def fno_sanitize_memory_use_after_dtor : Flag<["-"],
"fno-sanitize-memory-use-after-
morehouse created this revision.
Enable the compile-time flag -fsanitize-memory-use-after-dtor by
default. Note that the run-time option MSAN_OPTIONS=poison_in_dtor=1
still needs to be enabled for destructors to be poisoned.
https://reviews.llvm.org/D37860
Files:
clang/include/clang/Driver/Op
13 matches
Mail list logo
