dlj added inline comments.
Comment at: clang/test/lit.cfg:23
# the test runner updated.
-config.test_format = lit.formats.ShTest(execute_external)
+config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)
Minor nit: it seems reasonable enough to
rnk added inline comments.
Comment at: llvm/utils/lit/lit/llvm/config.py:92
def with_environment(self, variable, value, append_path = False):
+if append_path:
Rather than having an optional parameter that makes this append, maybe have a
new method
zturner created this revision.
Herald added a reviewer: modocache.
Herald added a subscriber: fedor.sergeev.
This is probably the last work I'm going to do here for a while. I still see
some room for improvement, but I think after this patch:
a) refactor begins to have diminishing returns
b) Th
