[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell closed this revision. martell added a comment. Landed in https://reviews.llvm.org/rL313082 Repository: rL LLVM https://reviews.llvm.org/D37727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D37727#868284, @rnk wrote: > Nice! IIUC, now that the gnu ld driver works on Windows we can remove this > logic. Thanks! We could have removed it before the addition of the gnu ld driver, I think the author just missed this target and possi

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Nice! IIUC, now that the gnu ld driver works on Windows we can remove this logic. Thanks! Repository: rL LLVM https://reviews.llvm.org/D37727 ___ c

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D37727#867751, @mstorsjo wrote: > I do the same by adding -rtlib=compiler-rt -stdlib=libc++ -fuse-ld=lld > -Qunused-arguments in the frontend script wrapper (a wrapper named > -w64-mingw32-clang that just calls clang -target -w64-mingw32 > -

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Looks good to me (but maybe someone else should approve it as well) Repository: rL LLVM https://reviews.llvm.org/D37727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell updated this revision to Diff 114801. martell added a comment. update tests Repository: rL LLVM https://reviews.llvm.org/D37727 Files: lib/Driver/ToolChains/MinGW.cpp test/Driver/mingw-useld.c Index: test/Driver/mingw-useld.c

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In https://reviews.llvm.org/D37727#867753, @martell wrote: > In https://reviews.llvm.org/D37727#867627, @mstorsjo wrote: > > > I'm not sure I like this direction. In my setups, a build-time default > > isn't right since I'm using the same clang builds for both native-on

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. In https://reviews.llvm.org/D37727#867627, @mstorsjo wrote: > I'm not sure I like this direction. In my setups, a build-time default isn't > right since I'm using the same clang builds for both native-on-linux building > (with the default `ld` as linker) and cross-build

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Actually, after testing this a bit more and looking at it, I withdraw my earlier complaints - this does indeed seem to work fine with my test setup. The generic `TC.GetLinkerPath()` picks up `-fuse-ld=lld` correctly and converts it into `ld.lld` which should be equival

[PATCH] D37727: Driver: Remove custom MinGW linker detection

2017-09-12 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. I'm not sure I like this direction. In my setups, a build-time default isn't right since I'm using the same clang builds for both native-on-linux building (with the default `ld` as linker) and cross-building targeting windows (using `ldd`), and keeping the code that re