This revision was automatically updated to reflect the committed changes.
Closed by commit rL315893: [clang-format] Break non-trailing comments, try 2
(authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D37695
Files:
cfe/trunk/lib/Format/BreakableToken.cpp
cfe/trunk/lib/F
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
looks good.
https://reviews.llvm.org/D37695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
krasimir added a comment.
ping
https://reviews.llvm.org/D37695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir updated this revision to Diff 116742.
krasimir added a comment.
- Change bool from Paren to Line and generalize it
https://reviews.llvm.org/D37695
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndente
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.h:270
+ // \c breakProtrudingToken.
+ bool LastBlockCommentWasBroken : 1;
+
We should be *very* careful when adding stuff to ParenState as every extra bit
of data and every extra compar
krasimir added a comment.
ping
https://reviews.llvm.org/D37695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir updated this revision to Diff 114617.
krasimir added a comment.
- Add the original test cases
https://reviews.llvm.org/D37695
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
unittests/Forma
krasimir created this revision.
Herald added a subscriber: klimek.
This patch enables `BreakableToken` to manage the formatting of non-trailing
block comments. It is a refinement of https://reviews.llvm.org/D37007.
We discovered that the optimizer outsmarts us on cases where breaking the
comment
