compnerd closed this revision.
compnerd added a comment.
SVN r313111
https://reviews.llvm.org/D37577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
I do not have commit rights - please commit this yourself, thanks!
https://reviews.llvm.org/D37577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd added a comment.
Do you have commit rights or would you like me to commit this on your behalf?
https://reviews.llvm.org/D37577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
frutiger updated this revision to Diff 114818.
frutiger added a comment.
Expand the acronym 'TLS' to 'thread-local storage' in documentation.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls_kind.py
include/clang-c/Index.h
tool
nik added inline comments.
Comment at: include/clang-c/Index.h:2840
+/**
+ * \brief Describe the "TLS kind" of the declaration referred to by a cursor.
+ */
I was wondering what "TLS" is and had to look it up. If not adapting the
function and enum name, then may
frutiger updated this revision to Diff 114701.
frutiger added a comment.
Use more specific target platform.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls_kind.py
include/clang-c/Index.h
tools/libclang/CIndex.cpp
tools/libc
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:32
+__declspec(thread) int tls_declspec;
+""", lang = 'cpp', flags=['-fms-extensions', '-target', 'amd64-win
frutiger updated this revision to Diff 114640.
frutiger added a comment.
Add test cases for `__declspec(thread)` and static TLS. Clean up formatting to
adhere to the project style.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls
frutiger added inline comments.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:14
+int tls_none;
+thread_local tls_dynamic;
+""", lang = 'cpp')
frutiger wrote:
> compnerd wrote:
> > Can we add a test case for static TLS as well please? Also, I think t
frutiger added inline comments.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:14
+int tls_none;
+thread_local tls_dynamic;
+""", lang = 'cpp')
compnerd wrote:
> Can we add a test case for static TLS as well please? Also, I think that we
> should add
compnerd added inline comments.
Comment at: bindings/python/tests/cindex/test_tls_kind.py:14
+int tls_none;
+thread_local tls_dynamic;
+""", lang = 'cpp')
Can we add a test case for static TLS as well please? Also, I think that we
should add a test case for `__
frutiger updated this revision to Diff 114256.
frutiger added a comment.
Exports 'TLSKind' in the '__all__' array.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls_kind.py
include/clang-c/Index.h
tools/libclang/CIndex.cpp
too
frutiger created this revision.
Introduce the 'TLS Kind' property of variable declarations through
libclang. Additionally, provide a Python accessor for it, and test that
functionality.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test
13 matches
Mail list logo
