jroelofs closed this revision.
jroelofs added a comment.
r312748
https://reviews.llvm.org/D37496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
itessier added a comment.
Do you mind submitting this CL? I don't have access to SVN.
https://reviews.llvm.org/D37496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
itessier added a comment.
In https://reviews.llvm.org/D37496#861746, @compnerd wrote:
> The change looks good. Can you please add some test cases for this? Or do
> existing test cases cover this already?
Should have added this to the description, but yes there are existing tests
that cover
compnerd added a comment.
The change looks good. Can you please add some test cases for this? Or do
existing test cases cover this already?
https://reviews.llvm.org/D37496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
itessier created this revision.
The ToolChain class validates the -mthread-model flag in the constructor which
doesn't work correctly since the thread model methods are virtual methods. The
check is moved into Clang::ConstructJob() when constructing the internal
command line.
https://reviews.
